fix: Add link to public pages to private NomCom pages#6345
fix: Add link to public pages to private NomCom pages#6345rjsparks merged 7 commits intoietf-tools:mainfrom
Conversation
Fixes ietf-tools#6343 Also fix highlighting of the active tab in the nav tab bar while I'm here.
|
I opened #6355 for the spurious CI failure. |
Codecov Report
@@ Coverage Diff @@
## main #6345 +/- ##
==========================================
- Coverage 88.69% 88.68% -0.01%
==========================================
Files 290 290
Lines 40390 40420 +30
==========================================
+ Hits 35823 35846 +23
- Misses 4567 4574 +7
|
jennifer-richards
left a comment
There was a problem hiding this comment.
I'm a little worried about hard-to-maintain template logic, see inline comments. I think probably the best thing would be to replace if selected in "a,b" with if selected == "a" or selected == "b" and leave the logic that computes the selected as it is.
|
I think I gave some bad advice - I was looking at creating the template tag I suggested as an alternative to the explosion of "or" clauses in the using what we've already got. Sorry for pointing you toward exploding the logic - if you'd like I can clean that up here or in a separate PR. |
Fixes #6343
Also fix highlighting of the active tab in the nav tab bar while I'm here, and remove old links that 404. Oh, and force-break some long/bogus UTF8 names.