feat: Allow review rejections to be undone#6312
Conversation
|
There's at least one rough edge (and this all needs tests). I ran through having cellar-flac assigned to me, and then rejecting/accepting/rejecting a few times. In my dev instance I've rejected the assignment there are no other assignements, and the open assignments management page doesn't allow the secretary to assign it to me again. The request, as I understand it, is to have me show up on the list here, but marked "has previously rejected reviewing this doc":
(right side truncated to not overshare current states) |
|
@russhousley @ajeanmahoney @kivinen This is what the assignment page will look like for a reviewer that has rejected a review before. This is Russ' view after both of us have been assigned and rejected the document. Is the UI here intuitive enough? And if you have this as secretaries (if you were logged in, Jean, you would see accept buttons for both of us), would you be ok not having the person show up in the list above?
|
… of suggested reviewers. This largely un-does d105f8b, at the request of at least one team secretary.
pselkirk
changed the title
Codecov Report
@@ Coverage Diff @@
## main #6312 +/- ##
==========================================
- Coverage 88.69% 88.67% -0.02%
==========================================
Files 290 290
Lines 40390 40428 +38
==========================================
+ Hits 35823 35851 +28
- Misses 4567 4577 +10
|
one_assignment still has to exclude reviewers who rejected the assignment, or they could end up being the suggested reviewer.
pselkirk
changed the title
|
I would typically work from the list on the Manage unassigned open review requests page rather than an individual review request page. As secretary, I would expect to see all available reviewers. On the individual review request page, the secretary is reassigning to Russ, yes? Maybe add a date to "Assignment rejected" under the reviewer name, e.g., "Assignment previously rejected 18 Sept 2023". Maybe there should be a Reject again button? |
| assignment.assigned_on = timezone.now() | ||
| assignment.save() | ||
| return assignment | ||
| return review_req.reviewassignment_set.create(state_id='assigned', reviewer=reviewer, assigned_on=timezone.now()) |
There was a problem hiding this comment.
Consider putting this in an else: clause
3 participants
Addresses most of #5978 and part of #6169