feat: require draft revisions in ipr disclosures. Explain missing ones. - #6160
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6160 +/- ##
=======================================
Coverage 88.68% 88.69%
=======================================
Files 290 290
Lines 40264 40300 +36
=======================================
+ Hits 35708 35743 +35
- Misses 4556 4557 +1
|
jennifer-richards
approved these changes
Aug 17, 2023
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
Approved! (A couple style nits and a possible (but not required) refactor noted inline.)
larseggert
suggested changes
Aug 17, 2023
larseggert
left a comment
larseggert
left a comment
Collaborator
There was a problem hiding this comment.
draft -> Internet-Draft everywhere
Member
Author
|
This also needs to test another facet - commit incoming |
jennifer-richards
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6155