fix: Server error from api_get_session_materials()#6025
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Jul 22, 2023
Merged
fix: Server error from api_get_session_materials()#6025rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
when session has no agenda
Codecov Report
@@ Coverage Diff @@
## main #6025 +/- ##
==========================================
- Coverage 88.67% 88.64% -0.04%
==========================================
Files 288 288
Lines 40001 40006 +5
==========================================
- Hits 35471 35463 -8
- Misses 4530 4543 +13
|
rjsparks
approved these changes
Jul 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5877
Guard with None added.
I checked the frontend reaction and it seems like JS will just create empty url instance that won’t be shown as URL. However I did no create test for that and I won’t be able to, so maybe further actions needed (maybe not)