fix: Shows requested reviews for doc fixes#6022
Conversation
| {% include "doc/review_assignment_summary.html" with current_doc_name=doc.name current_rev=doc.rev %} | ||
| {% endfor %} | ||
| {% for review_request in review_requests %} | ||
| {% include "doc/review_request_summary.html" with current_doc_name=doc.name current_rev=doc.rev %} |
There was a problem hiding this comment.
| {% include "doc/review_request_summary.html" with current_doc_name=doc.name current_rev=doc.rev %} | |
| {% include "doc/review_request_summary.html" with current_doc_name=doc.name current_rev=doc.rev only %} |
There was a problem hiding this comment.
I have no idea what that change would do so can't really comment on that.
There was a problem hiding this comment.
it passes only the current_doc_name and current_rev to the review_request_summary template instead of the full context available to the template you are calling {% include from.
There was a problem hiding this comment.
but I'm really confused - review_request_summary.html only uses review_request, why are you passing current_doc_name and current_rev to it?
There was a problem hiding this comment.
Because it is cut & paste from the above where it was giving same parameters to the doc/review_assignment_symmary.html.
I copied the review_assignment_summary.html as a base for the review_request_summary.html and at that point I did not know whether the lines using current_doc stays in or not.
In the end I did not need them as they are used to remove the version number from the line telling which version the review was done for in case it is current revision and document.
So most likely I should simply change it to
{% include "doc/review_request_summary.html" with review_request only %}
or do I need to use review_request=review_request before only?
There was a problem hiding this comment.
you need to use review_request=review_request
There was a problem hiding this comment.
Ok, now this should be done. I also did the same for the review_assignment_summary include.
kivinen
changed the title
rjsparks
changed the title
Codecov Report
@@ Coverage Diff @@
## main #6022 +/- ##
==========================================
- Coverage 88.67% 88.67% -0.01%
==========================================
Files 288 288
Lines 40001 40009 +8
==========================================
+ Hits 35471 35476 +5
- Misses 4530 4533 +3
|
rjsparks
changed the title
3 participants
Adds requested reviews to the document information page. Moved the due date of the incomplete reviews out from the badge to the actual text.
Fixes #4881.