Skip to content

fix: Make name/email lookups case-insensitive (#5972) #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 2 commits into from
Jul 22, 2023
Merged

fix: Make name/email lookups case-insensitive (#5972) #6007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53ae46b
fix: Make name/email lookups case-insensitive (#5972)
richsalz Jul 22, 2023
52b3ed6
fix: Use __iexact not __icontains
richsalz Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ietf/person/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,14 @@ def test_person_profile_without_email(self):
r = self.client.get(url)
self.assertContains(r, person.name, status_code=200)

def test_case_insensitive(self):
# Case insensitive seach
person = PersonFactory(name="Test Person")
url = urlreverse("ietf.person.views.profile", kwargs={ "email_or_name": "test person"})
r = self.client.get(url)
self.assertContains(r, person.name, status_code=200)
self.assertNotIn('More than one person', r.content.decode())

def test_person_profile_duplicates(self):
# same Person name and email - should not show on the profile as multiple Person records
person = PersonFactory(name="bazquux@example.com", user__email="bazquux@example.com")
Expand Down
4 changes: 2 additions & 2 deletions ietf/person/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ def ajax_select2_search(request, model_name):


def profile(request, email_or_name):
aliases = Alias.objects.filter(name=email_or_name)
aliases = Alias.objects.filter(name__iexact=email_or_name)
persons = set(a.person for a in aliases)

if '@' in email_or_name:
emails = Email.objects.filter(address=email_or_name)
emails = Email.objects.filter(address__iexact=email_or_name)
persons.update(e.person for e in emails)

persons = [p for p in persons if p and p.id]
Expand Down