Skip to content

fix: HTML-escape person name in tests #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 3 commits into from
Jul 21, 2023
Merged

fix: HTML-escape person name in tests #5986

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7a075b
fix: Add `mark_safe` to `person_link` to prevent HTML escaping
larseggert Jul 18, 2023
8a90897
Merge branch 'main' into fix-bjorn
larseggert Jul 21, 2023
d8b01ad
fix: Fix tests instead of marking name safe
larseggert Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ietf/group/tests_review.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_review_requests(self):
r = self.client.get(url)
self.assertEqual(r.status_code, 200)
self.assertContains(r, review_req.doc.name)
self.assertContains(r, assignment.reviewer.person.name)
self.assertContains(r, escape(assignment.reviewer.person.name))

url = urlreverse(ietf.group.views.review_requests, kwargs={ 'acronym': group.acronym })

Expand Down Expand Up @@ -183,7 +183,7 @@ def test_reviewer_overview(self):
urlreverse(ietf.group.views.reviewer_overview, kwargs={ 'acronym': group.acronym, 'group_type': group.type_id })]:
r = self.client.get(url)
self.assertEqual(r.status_code, 200)
self.assertContains(r, reviewer.name)
self.assertContains(r, escape(reviewer.name))
self.assertContains(r, review_req1.doc.name)
# without a login, reason for being unavailable should not be seen
self.assertNotContains(r, "Availability")
Expand Down