Conversation
* feat: infrastructure for statements doctype * chore: basic test framework * feat: basic statement document view * feat: show replaced statements * chore: black * fix: state help for statements * fix: cleanout non-relevant email expansions * feat: import iab statements, provide group statements tab * fix: guard against running import twice * feat: build redirect csv for iab statements * fix: set document state on import * feat: show published date on main doc view * feat: handle pdf statements * feat: create new and update statements * chore: copyright block updates * chore: remove flakes * chore: black * feat: add edit/new buttons for the secretariat * fix: address PR #5895 review comments
Codecov Report
@@ Coverage Diff @@
## main #5940 +/- ##
==========================================
- Coverage 88.67% 88.62% -0.05%
==========================================
Files 288 290 +2
Lines 40001 40178 +177
==========================================
+ Hits 35471 35609 +138
- Misses 4530 4569 +39
|
jennifer-richards
requested changes
Jul 7, 2023
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
One fix needed, plus a question
| # ] | ||
|
|
||
| DOCUMENT_PATH_PATTERN = '/assets/ietf-ftp/{doc.type_id}/' | ||
| DOCUMENT_PATH_PATTERN = '/assets/ietfdata/doc/{doc.type_id}/' |
Member
There was a problem hiding this comment.
Should we move the assets around on the dev container before merging this, or deal with it later? (Earlier you said there'd be other fallout -- just confirming whether this is intentional or was forgotten)
jennifer-richards
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.