Skip to content

feat: Add bibxml button to document info page - #5921

Merged
rjsparks merged 2 commits into
ietf-tools:mainfrom
pselkirk:fix-5908
Jul 7, 2023
Merged

feat: Add bibxml button to document info page#5921
rjsparks merged 2 commits into
ietf-tools:mainfrom
pselkirk:fix-5908

Conversation

@pselkirk

@pselkirk pselkirk commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Fixes #5908

@codecov

codecov Bot commented Jul 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5921 (b64ce96) into main (09f3477) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5921   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files         288      288           
  Lines       40001    40002    +1     
=======================================
+ Hits        35471    35472    +1     
  Misses       4530     4530           
Impacted Files Coverage Δ
ietf/doc/utils.py 87.15% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

Comment thread ietf/doc/utils.py Outdated
@rjsparks

rjsparks commented Jul 6, 2023

Copy link
Copy Markdown
Member

I continue to have misgivings about not pointing to bib.ietf.org right away.
@kesara - could I get a second opinion?

@kesara

kesara commented Jul 6, 2023

Copy link
Copy Markdown
Member

I continue to have misgivings about not pointing to bib.ietf.org right away.

@kesara - could I get a second opinion?

There's a delay of about ~3 hours for new BibXML entries to be available of bib.ietf.org.

@rjsparks

rjsparks commented Jul 7, 2023

Copy link
Copy Markdown
Member

ok - we'll go with this for now then.

@rjsparks
rjsparks merged commit bae2048 into ietf-tools:main Jul 7, 2023
@pselkirk
pselkirk deleted the fix-5908 branch July 7, 2023 20:26
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add xml reference as button on document page

3 participants