-
Notifications
You must be signed in to change notification settings - Fork 755
feat: support iab and iesg statements. Import iab statements. #5895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rjsparks
merged 19 commits into
ietf-tools:feat/iabstatements
from
rjsparks:iabstatements
Jun 30, 2023
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
97220a5
feat: infrastructure for statements doctype
rjsparks a45186e
chore: basic test framework
rjsparks 80035dd
feat: basic statement document view
rjsparks 8229dd5
feat: show replaced statements
rjsparks 4b612eb
chore: black
rjsparks 36e1841
fix: state help for statements
rjsparks 79989d7
fix: cleanout non-relevant email expansions
rjsparks e505299
feat: import iab statements, provide group statements tab
rjsparks 3417ad5
fix: guard against running import twice
rjsparks 78c92f5
feat: build redirect csv for iab statements
rjsparks dac0cd3
fix: set document state on import
rjsparks 5aae1e4
feat: show published date on main doc view
rjsparks 0386acf
feat: handle pdf statements
rjsparks 583c04b
feat: create new and update statements
rjsparks 1521f8e
chore: copyright block updates
rjsparks ec210bc
chore: remove flakes
rjsparks 052e575
chore: black
rjsparks c669714
feat: add edit/new buttons for the secretariat
rjsparks cbfc597
fix: address PR #5895 review comments
rjsparks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| # Copyright The IETF Trust 2023, All Rights Reserved | ||
|
|
||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
| dependencies = [ | ||
| ("doc", "0004_alter_dochistory_ad_alter_dochistory_shepherd_and_more"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AlterField( | ||
| model_name="docevent", | ||
| name="type", | ||
| field=models.CharField( | ||
| choices=[ | ||
| ("new_revision", "Added new revision"), | ||
| ("new_submission", "Uploaded new revision"), | ||
| ("changed_document", "Changed document metadata"), | ||
| ("added_comment", "Added comment"), | ||
| ("added_message", "Added message"), | ||
| ("edited_authors", "Edited the documents author list"), | ||
| ("deleted", "Deleted document"), | ||
| ("changed_state", "Changed state"), | ||
| ("changed_stream", "Changed document stream"), | ||
| ("expired_document", "Expired document"), | ||
| ("extended_expiry", "Extended expiry of document"), | ||
| ("requested_resurrect", "Requested resurrect"), | ||
| ("completed_resurrect", "Completed resurrect"), | ||
| ("changed_consensus", "Changed consensus"), | ||
| ("published_rfc", "Published RFC"), | ||
| ( | ||
| "added_suggested_replaces", | ||
| "Added suggested replacement relationships", | ||
| ), | ||
| ( | ||
| "reviewed_suggested_replaces", | ||
| "Reviewed suggested replacement relationships", | ||
| ), | ||
| ("changed_action_holders", "Changed action holders for document"), | ||
| ("changed_group", "Changed group"), | ||
| ("changed_protocol_writeup", "Changed protocol writeup"), | ||
| ("changed_charter_milestone", "Changed charter milestone"), | ||
| ("initial_review", "Set initial review time"), | ||
| ("changed_review_announcement", "Changed WG Review text"), | ||
| ("changed_action_announcement", "Changed WG Action text"), | ||
| ("started_iesg_process", "Started IESG process on document"), | ||
| ("created_ballot", "Created ballot"), | ||
| ("closed_ballot", "Closed ballot"), | ||
| ("sent_ballot_announcement", "Sent ballot announcement"), | ||
| ("changed_ballot_position", "Changed ballot position"), | ||
| ("changed_ballot_approval_text", "Changed ballot approval text"), | ||
| ("changed_ballot_writeup_text", "Changed ballot writeup text"), | ||
| ("changed_rfc_editor_note_text", "Changed RFC Editor Note text"), | ||
| ("changed_last_call_text", "Changed last call text"), | ||
| ("requested_last_call", "Requested last call"), | ||
| ("sent_last_call", "Sent last call"), | ||
| ("scheduled_for_telechat", "Scheduled for telechat"), | ||
| ("iesg_approved", "IESG approved document (no problem)"), | ||
| ("iesg_disapproved", "IESG disapproved document (do not publish)"), | ||
| ("approved_in_minute", "Approved in minute"), | ||
| ("iana_review", "IANA review comment"), | ||
| ("rfc_in_iana_registry", "RFC is in IANA registry"), | ||
| ( | ||
| "rfc_editor_received_announcement", | ||
| "Announcement was received by RFC Editor", | ||
| ), | ||
| ("requested_publication", "Publication at RFC Editor requested"), | ||
| ( | ||
| "sync_from_rfc_editor", | ||
| "Received updated information from RFC Editor", | ||
| ), | ||
| ("requested_review", "Requested review"), | ||
| ("assigned_review_request", "Assigned review request"), | ||
| ("closed_review_request", "Closed review request"), | ||
| ("closed_review_assignment", "Closed review assignment"), | ||
| ("downref_approved", "Downref approved"), | ||
| ("posted_related_ipr", "Posted related IPR"), | ||
| ("removed_related_ipr", "Removed related IPR"), | ||
| ("changed_editors", "Changed BOF Request editors"), | ||
| ("published_statement", "Published statement"), | ||
| ], | ||
| max_length=50, | ||
| ), | ||
| ), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Copyright The IETF Trust 2023, All Rights Reserved | ||
|
|
||
| from django.db import migrations | ||
|
|
||
|
|
||
| def forward(apps, schema_editor): | ||
| StateType = apps.get_model("doc", "StateType") | ||
| State = apps.get_model("doc", "State") | ||
|
|
||
| StateType.objects.create(slug="statement", label="Statement State") | ||
| State.objects.create( | ||
| slug="active", | ||
| type_id="statement", | ||
| name="Active", | ||
| order=0, | ||
| desc="The statement is active", | ||
| ) | ||
| State.objects.create( | ||
| slug="replaced", | ||
| type_id="statement", | ||
| name="Replaced", | ||
| order=0, | ||
| desc="The statement has been replaced", | ||
| ) | ||
|
|
||
|
|
||
| def reverse(apps, schema_editor): | ||
| StateType = apps.get_model("doc", "StateType") | ||
| State = apps.get_model("doc", "State") | ||
|
|
||
| State.objects.filter(type_id="statement").delete() | ||
| StateType.objects.filter(slug="statement").delete() | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
| dependencies = [ | ||
| ("doc", "0005_alter_docevent_type"), | ||
| ("name", "0004_statements"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.RunPython(forward, reverse), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These sorts of files are still in
/assets/ietf-ftpon my system - do we need to update the dev images to match this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be other fallout for the dev system, but this needs to happen.