fix: replace deprecated bootstrap things#5858
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5858 +/- ##
==========================================
- Coverage 88.67% 88.63% -0.05%
==========================================
Files 288 288
Lines 40001 40014 +13
==========================================
- Hits 35471 35466 -5
- Misses 4530 4548 +18
|
rjsparks
reviewed
Jun 21, 2023
| {% analytical_body_top %} | ||
| <a class="visually-hidden visually-hidden-focusable" href="#content">Skip to main content</a> | ||
| <nav class="navbar navbar-expand-lg {% if server_mode and server_mode != "production" %} navbar-light bg-warning {% else %} navbar-dark bg-secondary {% endif %} {% if navbar_mode %} {{ navbar_mode }} {% else %} fixed-top {% endif %}"> | ||
| <nav class="navbar navbar-expand-lg {% if server_mode and server_mode != "production" %} navbar-light bg-warning {% else %} bg-secondary {% endif %} {% if navbar_mode %} {{ navbar_mode }} {% else %} fixed-top {% endif %}"> |
Member
There was a problem hiding this comment.
I read what's at https://getbootstrap.com/docs/5.2/components/navbar/ differently. It says there that navbar-light has been deprecated and that navbar-dark is still around, but re-implemented?
Member
There was a problem hiding this comment.
The migration notes for 5.3 mentions navbar-dark being deprecated:
https://getbootstrap.com/docs/5.3/migration/#color-modes-1
Member
There was a problem hiding this comment.
but navbar-light is also still deprecated, no?
NGPixel
changed the title
rjsparks
approved these changes
Jul 18, 2023
NGPixel
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5857