feat: render charters on about page using markdown#5795
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Jun 13, 2023
Merged
feat: render charters on about page using markdown#5795rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5795 +/- ##
==========================================
- Coverage 88.67% 88.67% -0.01%
==========================================
Files 288 288
Lines 39936 39937 +1
==========================================
Hits 35413 35413
- Misses 4523 4524 +1
|
jennifer-richards
changed the title
jennifer-richards
approved these changes
Jun 11, 2023
Member
Author
|
@larseggert wants to see if he can tweak this for minor improvements before it is merged. |
Collaborator
|
I don't think there is anything more I can easily do. Fixing the oddities would entail switching libs and/or writing custom plugins. |
Member
Author
|
Mutter: foot-gunned by the GH stateful type-of-merge button once again... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remember the
/group/<acronym>/about/rendertestview for a before/after comparison. (This PR fixes a js issue in that view).The last time we pressed people to look at rendertest, I don't think we were using
nl2br, so some of the really old charters with strange linebreaks in their text files will still just look strange, but overall, using it will likely produce the least surprise.cc: @larseggert