test: ignore acceptable order change - #5727
Merged
Merged
Conversation
jennifer-richards
approved these changes
May 31, 2023
jennifer-richards
approved these changes
May 31, 2023
| ) | ||
| self.assertFalse(sessions[0].joint_with_groups.count()) | ||
| self.assertEqual(list(sessions[1].joint_with_groups.all()), [group3, group4]) | ||
| self.assertEqual(set(list(sessions[1].joint_with_groups.all())), set([group3, group4])) |
Member
There was a problem hiding this comment.
Does the set() need the list() first? I'd have thought it can work straight from the QuerySet.
Could also use a set literal {group3, group4}
Up to you whether you care enough about this to change.
Codecov Report
@@ Coverage Diff @@
## main #5727 +/- ##
==========================================
+ Coverage 88.73% 88.74% +0.01%
==========================================
Files 285 285
Lines 39852 39852
==========================================
+ Hits 35362 35367 +5
+ Misses 4490 4485 -5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.