Skip to content

feat: disable login button on submit - #5718

Merged
rjsparks merged 2 commits into
ietf-tools:mainfrom
NGPixel:main
May 31, 2023
Merged

feat: disable login button on submit#5718
rjsparks merged 2 commits into
ietf-tools:mainfrom
NGPixel:main

Conversation

@NGPixel

@NGPixel NGPixel commented May 30, 2023

Copy link
Copy Markdown
Member

No description provided.

@NGPixel
NGPixel requested a review from rjsparks May 30, 2023 22:02
@codecov

codecov Bot commented May 30, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5718 (ab5bec0) into main (d595aac) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ab5bec0 differs from pull request most recent head 8574c1c. Consider uploading reports for the commit 8574c1c to get more accurate results

@@           Coverage Diff           @@
##             main    #5718   +/-   ##
=======================================
  Coverage   88.73%   88.74%           
=======================================
  Files         285      285           
  Lines       39852    39852           
=======================================
+ Hits        35362    35365    +3     
+ Misses       4490     4487    -3     

see 3 files with indirect coverage changes

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Would be nice to move away from inline scripts though.

@NGPixel
NGPixel requested a review from jennifer-richards May 31, 2023 19:11
@rjsparks
rjsparks merged commit 1ec403d into ietf-tools:main May 31, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants