Skip to content

fix: show meeting timezone when editing sessions - #5619

Merged
rjsparks merged 2 commits into
ietf-tools:mainfrom
rjsparks:fix5353
May 15, 2023
Merged

fix: show meeting timezone when editing sessions#5619
rjsparks merged 2 commits into
ietf-tools:mainfrom
rjsparks:fix5353

Conversation

@rjsparks

Copy link
Copy Markdown
Member

Fixes #5353

@codecov

codecov Bot commented May 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5619 (591a429) into main (6089d47) will decrease coverage by 0.02%.
The diff coverage is 76.74%.

@@            Coverage Diff             @@
##             main    #5619      +/-   ##
==========================================
- Coverage   88.75%   88.73%   -0.02%     
==========================================
  Files         285      285              
  Lines       39810    39838      +28     
==========================================
+ Hits        35333    35350      +17     
- Misses       4477     4488      +11     
Impacted Files Coverage Δ
ietf/doc/views_doc.py 91.61% <62.50%> (-0.04%) ⬇️
ietf/meeting/templatetags/session_filters.py 87.50% <85.18%> (-4.17%) ⬇️

... and 3 files with indirect coverage changes

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, though it'll print the timezone as "PST8PDT" or "America/Halifax" rather than a more typical brief description like "PDT" or "ADT". I don't think that's a problem, just pointing it out in case you happened to test with UTC where it might not have been obvious.

@rjsparks
rjsparks merged commit 7dbac20 into ietf-tools:main May 15, 2023
@rjsparks
rjsparks deleted the fix5353 branch May 15, 2023 19:50
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Another location where meeting time zone info is incorrect

2 participants