Skip to content

fix: Unbreak HTMLized table of contents - #5486

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
larseggert:fix-5483
Apr 12, 2023
Merged

fix: Unbreak HTMLized table of contents#5486
rjsparks merged 1 commit into
ietf-tools:mainfrom
larseggert:fix-5483

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

Fixes #5483

@codecov

codecov Bot commented Apr 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5486 (e69c9b9) into main (84c1fa1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5486   +/-   ##
=======================================
  Coverage   88.80%   88.81%           
=======================================
  Files         285      285           
  Lines       39611    39611           
=======================================
+ Hits        35177    35180    +3     
+ Misses       4434     4431    -3     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks

Copy link
Copy Markdown
Member

@NGPixel How can we get tests around this?

@larseggert

Copy link
Copy Markdown
Collaborator Author

At some point I added code so that CI fails when there are unexpected messages in the JS console - but that doesn't seem to trigger anymore?

@NGPixel

NGPixel commented Apr 12, 2023

Copy link
Copy Markdown
Member

We could add a simple Playwright test on an internet draft we choose. But if the bug only occurred on recent drafts rather than all of them, it might not be helpful at catching future bugs.

@rjsparks
rjsparks merged commit 0f1a774 into ietf-tools:main Apr 12, 2023
richsalz pushed a commit to richsalz/datatracker that referenced this pull request Apr 13, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 16, 2023
@larseggert
larseggert deleted the fix-5483 branch April 17, 2023 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc/html Contents empty

3 participants