fix: move meeting management items from base menu Documents tab to Meetings tab (fixes #3897 and #4005)#5422
fix: move meeting management items from base menu Documents tab to Meetings tab (fixes #3897 and #4005)#5422Spectre17 wants to merge 2 commits intoietf-tools:mainfrom
Conversation
…etings tab (fixes ietf-tools#3897 and ietf-tools#4005) Rearranges elements of the optional Manage block in Documents so that they appear in Meetings instead. This is for things like "xxxx wg meetings". Also, put role restrictions around whether "Request a session" and "Request an interim meeting" appear under the Meetings tab.
rjsparks
left a comment
There was a problem hiding this comment.
The role based if clauses here do not match real needs (many other group types use interims for example). Lets talk about using leveraging existing utilities to decide when to offer links instead.
Codecov Report
@@ Coverage Diff @@
## main #5422 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 285 285
Lines 39525 39525
=======================================
+ Hits 35100 35101 +1
+ Misses 4425 4424 -1 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The list of roles I used was based on what was being enforced in the code itself. I just added the role-based restriction to the HTML so that users who were going to trip the code restrictions instead hit HTML restrictions first. Two notes:
|
|
overtaken by #6586 |
Rearranges elements of the optional Manage block in Documents so that they appear in Meetings instead. This is for things like "xxxx wg meetings". Also, put role restrictions around whether "Request a session" and "Request an interim meeting" appear under the Meetings tab.