Skip to content

fix: move meeting management items from base menu Documents tab to Meetings tab (fixes #3897 and #4005)#5422

Closed
Spectre17 wants to merge 2 commits intoietf-tools:mainfrom
Spectre17:yokohama-3897
Closed

fix: move meeting management items from base menu Documents tab to Meetings tab (fixes #3897 and #4005)#5422
Spectre17 wants to merge 2 commits intoietf-tools:mainfrom
Spectre17:yokohama-3897

Conversation

@Spectre17
Copy link
Copy Markdown
Collaborator

Rearranges elements of the optional Manage block in Documents so that they appear in Meetings instead. This is for things like "xxxx wg meetings". Also, put role restrictions around whether "Request a session" and "Request an interim meeting" appear under the Meetings tab.

…etings tab (fixes ietf-tools#3897 and ietf-tools#4005)

Rearranges elements of the optional Manage block in Documents so that they appear in Meetings instead. This is for things like "xxxx wg meetings". Also, put role restrictions around whether "Request a session" and "Request an interim meeting" appear under the Meetings tab.
@Spectre17 Spectre17 changed the title Fix: move meeting management items from base menu Documents tab to Meetings tab (fixes #3897 and #4005) fix: move meeting management items from base menu Documents tab to Meetings tab (fixes #3897 and #4005) Mar 25, 2023
Copy link
Copy Markdown
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The role based if clauses here do not match real needs (many other group types use interims for example). Lets talk about using leveraging existing utilities to decide when to offer links instead.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2023

Codecov Report

Merging #5422 (165f691) into main (736382a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5422   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         285      285           
  Lines       39525    39525           
=======================================
+ Hits        35100    35101    +1     
+ Misses       4425     4424    -1     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Spectre17
Copy link
Copy Markdown
Collaborator Author

The list of roles I used was based on what was being enforced in the code itself. I just added the role-based restriction to the HTML so that users who were going to trip the code restrictions instead hit HTML restrictions first. Two notes:

  1. I'm happy to change the restrictions to a different set or use an existing utility if it can be incorporated into the HTML template.

  2. That part of the merge request is not critical to fixing the issue in any case - it was a secondary thing I hit while in that HTML files, so we could break it out to a separate pull request and allow the main fix to be incorporated without being tied to work on the restrictions.

@rjsparks rjsparks changed the base branch from feat/postgres to main April 12, 2023 22:40
@rjsparks
Copy link
Copy Markdown
Member

rjsparks commented Nov 5, 2023

overtaken by #6586

@rjsparks rjsparks closed this Nov 5, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants