Skip to content

feat: Allow password reset with non username email address - #5419

Merged
rjsparks merged 1 commit into
ietf-tools:feat/postgresfrom
kesara:feat/allow-reset-password-with-non-username
Mar 28, 2023
Merged

feat: Allow password reset with non username email address#5419
rjsparks merged 1 commit into
ietf-tools:feat/postgresfrom
kesara:feat/allow-reset-password-with-non-username

Conversation

@kesara

@kesara kesara commented Mar 25, 2023

Copy link
Copy Markdown
Member

This change allows password reset with any email address associated with the account.
The password reset will only be sent to the active email addresses associated with the account.

Fixes #5057

This change allows password reset with any email address associated with the
account.
The password reset will only be sent to the active email addresses associated
with the account.

Fixes ietf-tools#5057

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think will allow an inactive secondary address to be used to request the reset but will not send the link to that address. As long as we don't allow an inactive address to be associated with a different User that seems reasonable to me (thinking of the case where someone has forgotten which addresses are tied to their account).

@kesara

kesara commented Mar 27, 2023

Copy link
Copy Markdown
Member Author

I think will allow an inactive secondary address to be used to request the reset but will not send the link to that address. As long as we don't allow an inactive address to be associated with a different User that seems reasonable to me (thinking of the case where someone has forgotten which addresses are tied to their account).

Yes, that was the idea. To allow people to request for password reset with an inactive email address as well but not to send the link to inactive email addresses.

If we allow inactive email addresses to be associated with a different user, I think we will have a lot of data integrity issues.

@rjsparks
rjsparks merged commit b0c7641 into ietf-tools:feat/postgres Mar 28, 2023
@kesara
kesara deleted the feat/allow-reset-password-with-non-username branch March 28, 2023 07:15
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants