fix: Add "simple" list of nomcom volunteers (#4732)#5412
fix: Add "simple" list of nomcom volunteers (#4732)#5412richsalz wants to merge 5 commits intoietf-tools:mainfrom
Conversation
|
I am not sure if it is better to have multiple |
| </a> | ||
| </li> | ||
| <li class="dropdown-item"> | ||
| <a href="{% url 'ietf.nomcom.views.private_volunteers' year "simple" %}"> |
There was a problem hiding this comment.
This is not doing what you intend, I think. There's nothing in the urls to reverse this to. If possible, lets talk about this in yokohama (I'm at the hackathon today).
The general shape of where you're going reads well enough. The tradeoff of breaking this template into one big if/then or dispatching two two different templates is duplication of the presentation, making it more likely that edits take things out of sync. Consider whether reordering columns so that the verbose columns were always rightmost would work - that would make the tradeoff easier to resolve. |
For doing cut/paste to IETF announcements of the list of volunteers, it can be very convenient to just have a simple text list of name and affiliation. We implement this by adding a "mode" flag to the volunteer functions, and omitting columns in the template in non-full (i.e., simple) mode.
Suggested by Robert; reduces the number of if/endif blocks.
It was on the function call, which was an off-by-one-line bug :)
It was on the function call, which was an off-by-one-line bug :)
|
superceeded by #5578. |
2 participants
For doing cut/paste to IETF announcements of the list of volunteers, it can be very convenient to just have a simple text list of name and affiliation. We implement this by adding a "mode" flag to the volunteer functions, and omitting columns in the template in non-full (i.e., simple) mode.