chore: Update test docs to postgresql; remove extraneous sqlite stuff#5400
Conversation
| if [ ! -f "$WORKSPACEDIR/ietf/settings_local_sqlitetest.py" ]; then | ||
| echo "Setting up a default settings_local_sqlitetest.py ..." | ||
| cp $WORKSPACEDIR/docker/configs/settings_local_sqlitetest.py $WORKSPACEDIR/ietf/settings_local_sqlitetest.py | ||
| else | ||
| echo "Using existing ietf/settings_local_sqlitetest.py file" | ||
| if ! cmp -s $WORKSPACEDIR/docker/configs/settings_local_sqlitetest.py $WORKSPACEDIR/ietf/settings_local_sqlitetest.py; then | ||
| echo "NOTE: Differences detected compared to docker/configs/settings_local_sqlitetest.py!" | ||
| echo "We'll assume you made these deliberately." | ||
| fi | ||
| fi | ||
|
|
There was a problem hiding this comment.
@NGPixel I don't think any devs used settings_local_sqlitetest. Did any actions? We don't have a comparable settings_local_postgrestest, and I suspect we don't need one?
There was a problem hiding this comment.
@rjsparks It is used in some workflows, e.g.:
https://github.com/ietf-tools/datatracker/blob/main/.github/workflows/build.yml#L163-L165
There was a problem hiding this comment.
But that's in the main branch, not feat/postgres. The corresponding lines are:
https://github.com/ietf-tools/datatracker/blob/feat/postgres/.github/workflows/build.yml#L156-L158
which use settings_postgrestest, not settings_local_sqlitetest
| /settings_local_vite.py | ||
| /settings_mysqldb.py | ||
| /settings_postgresqldb.py | ||
| /settings_postgrestest.py |
There was a problem hiding this comment.
This file is in git and does not need to be ignored. Please revert this change
There was a problem hiding this comment.
Reverted by 012de38 although I don't quite understand why to .gitignore settings_postgresqldb.py and not settings_postgrestest.py
There was a problem hiding this comment.
settings_postgresqldb.py is source-controlled in docker/configs/, and is copied into ietf/ as the dev environment is built - it's runtime configuration for the actual app, not the tests. settings_postgrestest.py is source-controlled in ietf/.
That schism is an artifact of history, and we could normalize what we're doing, but that's a bigger task than this PR should take on.
Codecov Report
@@ Coverage Diff @@
## feat/postgres #5400 +/- ##
==============================================
Coverage 88.80% 88.80%
==============================================
Files 285 285
Lines 39525 39529 +4
==============================================
+ Hits 35100 35104 +4
Misses 4425 4425 see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Jim - I think something went wrong with a rebase here - can could look and clean it back to the intended changes? |
|
Yes, I did a sync of my fork to the main repository and it seems to have done bad things. I haven't run into that before, probably because I wasn't working on such an active project. Let me see if I can fix it up; otherwise I'll just close this PR and create a new one. |
|
@rjsparks With help from Justin Richer, I got this pull request cleaned up. Please take another look. |
3 participants
No description provided.