Skip to content

fix: Edit "You've been nominated" text (#4641) - #5357

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
richsalz:fix-4641
Apr 23, 2023
Merged

fix: Edit "You've been nominated" text (#4641)#5357
rjsparks merged 1 commit into
ietf-tools:mainfrom
richsalz:fix-4641

Conversation

@richsalz

Copy link
Copy Markdown
Collaborator

Mention that the schedule is posted to ietf-announce and give a link to subscribe to that. Use vague wording to handle all cases.

@richsalz
richsalz force-pushed the fix-4641 branch 4 times, most recently from b21e1ee to 802582d Compare March 16, 2023 18:11
@richsalz

Copy link
Copy Markdown
Collaborator Author

Sorry for the noise; forced push/rebase etc. Learning how to submit PR's here.

Comment thread ietf/dbtemplate/fixtures/nomcom_templates.xml
Comment thread ietf/nomcom/migrations/0001_initial.py
Comment thread ietf/nomcom/models.py
@richsalz

Copy link
Copy Markdown
Collaborator Author

Let's resolve this at the sprint and you can teach me then.

@richsalz
richsalz force-pushed the fix-4641 branch 2 times, most recently from 3c0bbf3 to 604c808 Compare March 25, 2023 02:26
@richsalz
richsalz changed the base branch from main to feat/postgres March 25, 2023 02:28
Comment thread ietf/nomcom/migrations/0001_initial.py Outdated
@rjsparks

Copy link
Copy Markdown
Member

holding to bring in after the postgres transition is complete

@rjsparks
rjsparks changed the base branch from feat/postgres to main April 13, 2023 21:19
@richsalz

Copy link
Copy Markdown
Collaborator Author

I think this is ready for review now.

Mention that the schedule is posted to ietf-announce and give a link
to subscribe to that.  Use vague wording to handle all cases.

Also add reminder when to not uncheck the "send automatically" box.
@richsalz richsalz changed the title Update "You've been nominated" email fix: Edit "You've been nominated" text (#4641) Apr 17, 2023
@rjsparks
rjsparks merged commit 8c98abb into ietf-tools:main Apr 23, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 27, 2023
@richsalz
richsalz deleted the fix-4641 branch May 2, 2023 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants