Skip to content

fix: Use correct group type in session request email response - #5275

Merged
rjsparks merged 5 commits into
ietf-tools:mainfrom
larseggert:fix-2120
Mar 7, 2023
Merged

fix: Use correct group type in session request email response#5275
rjsparks merged 5 commits into
ietf-tools:mainfrom
larseggert:fix-2120

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

Fixes #2120

Comment thread ietf/secr/sreq/views.py Outdated
Comment thread ietf/secr/sreq/views.py Outdated
@larseggert
larseggert requested a review from rjsparks March 6, 2023 07:37
@codecov

codecov Bot commented Mar 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5275 (6bb82aa) into main (0ec1264) will decrease coverage by 0.01%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main    #5275      +/-   ##
==========================================
- Coverage   88.58%   88.58%   -0.01%     
==========================================
  Files         295      294       -1     
  Lines       40114    40071      -43     
==========================================
- Hits        35534    35495      -39     
+ Misses       4580     4576       -4     
Impacted Files Coverage Δ
ietf/iesg/urls.py 100.00% <ø> (ø)
ietf/meeting/models.py 86.03% <ø> (-0.05%) ⬇️
ietf/meeting/urls.py 81.25% <ø> (ø)
ietf/iesg/views.py 92.53% <85.18%> (-0.71%) ⬇️
ietf/secr/sreq/views.py 91.37% <85.71%> (+0.21%) ⬆️
ietf/doc/mails.py 96.20% <100.00%> (ø)
ietf/doc/utils_search.py 80.58% <100.00%> (ø)
ietf/group/views.py 90.95% <100.00%> (+0.09%) ⬆️
ietf/ietfauth/views.py 92.12% <100.00%> (+1.09%) ⬆️
ietf/meeting/helpers.py 89.84% <100.00%> (-0.07%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks

rjsparks commented Mar 6, 2023

Copy link
Copy Markdown
Member

I updated the verbose names in production.

Comment thread ietf/secr/sreq/views.py Outdated
Comment thread ietf/secr/sreq/views.py Outdated
@larseggert
larseggert requested a review from rjsparks March 7, 2023 09:53
@rjsparks
rjsparks merged commit 98c24d1 into ietf-tools:main Mar 7, 2023
@rjsparks

rjsparks commented Mar 7, 2023

Copy link
Copy Markdown
Member

This has one rough edge that we won't encounter in practice. There is one group verbose name The Internet Society where inflecting a in front of will not produce a correct phrase, but so far the internet society isn't requesting sessions.

@larseggert
larseggert deleted the fix-2120 branch March 7, 2023 16:31
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong group type in scheduling request email response

2 participants