fix: Use correct group type in session request email response - #5275
Merged
Conversation
rjsparks
requested changes
Mar 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #5275 +/- ##
==========================================
- Coverage 88.58% 88.58% -0.01%
==========================================
Files 295 294 -1
Lines 40114 40071 -43
==========================================
- Hits 35534 35495 -39
+ Misses 4580 4576 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
I updated the verbose names in production. |
rjsparks
reviewed
Mar 6, 2023
rjsparks
requested changes
Mar 6, 2023
rjsparks
approved these changes
Mar 7, 2023
Member
|
This has one rough edge that we won't encounter in practice. There is one group verbose name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2120