feat: Return to expected schedule after editing sessions/timeslots#5158
Merged
rjsparks merged 10 commits intoietf-tools:mainfrom Feb 16, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5158 +/- ##
==========================================
+ Coverage 88.50% 88.53% +0.03%
==========================================
Files 295 295
Lines 40015 40046 +31
==========================================
+ Hits 35415 35456 +41
+ Misses 4600 4590 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rjsparks
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3591.
The "Edit rooms" button from the timeslot editor still leads off into the secr app. I did not update that to return cleanly - still have to use browser history or navigate back through the agenda list. When we replace the secr app for editing rooms we can clean this up.