fix: restore display of additional resources.#4956
Merged
rjsparks merged 2 commits intoietf-tools:mainfrom Jan 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4956 +/- ##
==========================================
- Coverage 88.47% 88.47% -0.01%
==========================================
Files 296 296
Lines 39805 39818 +13
==========================================
+ Hits 35219 35229 +10
- Misses 4586 4589 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
larseggert
approved these changes
Jan 9, 2023
jennifer-richards
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4948
@larseggert - I couldn't find why the lines I removed from document_info.html had come in - the logic in them made no sense - what were they for?
The resources are not showing on the htmlized page because the view always passes in a DocHistory object, which has no docextresource_set. If we're willing to show what the current resources are even when looking at an older document, the view could decorate the history being passed to the template with it (but this may cause confusion).
We may want to consider capturing the external resources each time a DocHistory is created (similar to RelatedDocHistory) at some point in the future.