Skip to content

fix: handle names with endings that might parse as versions better#4897

Merged
rjsparks merged 7 commits intoietf-tools:mainfrom
rjsparks:alternative-fix-4855
Dec 20, 2022
Merged

fix: handle names with endings that might parse as versions better#4897
rjsparks merged 7 commits intoietf-tools:mainfrom
rjsparks:alternative-fix-4855

Conversation

@rjsparks
Copy link
Copy Markdown
Member

fixes #4855

@rjsparks rjsparks marked this pull request as draft December 14, 2022 23:10
@rjsparks
Copy link
Copy Markdown
Member Author

@Lars - this is a proposed replacement for #4862.
Either still need tests (and probably a light refactor of the method to make it more testable).

@rjsparks
Copy link
Copy Markdown
Member Author

Either should also try to fix #4898 at the same time.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2022

Codecov Report

Merging #4897 (528ed15) into main (bc1cba1) will increase coverage by 0.00%.
The diff coverage is 85.41%.

@@           Coverage Diff           @@
##             main    #4897   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files         296      296           
  Lines       39795    39805   +10     
=======================================
+ Hits        35208    35218   +10     
  Misses       4587     4587           
Impacted Files Coverage Δ
ietf/review/utils.py 89.57% <ø> (-0.03%) ⬇️
ietf/doc/utils.py 88.05% <77.77%> (-0.16%) ⬇️
ietf/doc/views_doc.py 91.17% <86.48%> (+0.39%) ⬆️
ietf/doc/models.py 88.16% <100.00%> (+0.01%) ⬆️
ietf/doc/templatetags/ballot_icon.py 84.82% <100.00%> (ø)
ietf/doc/views_search.py 89.23% <0.00%> (-0.42%) ⬇️
ietf/nomcom/utils.py 91.30% <0.00%> (-0.25%) ⬇️
ietf/person/utils.py 86.98% <0.00%> (+0.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@larseggert
Copy link
Copy Markdown
Collaborator

Let's use this one as a base, will close #4862.

@rjsparks
Copy link
Copy Markdown
Member Author

OK - I've looked more closely and there's not a quick refactor that would let us test the small bit of logic that's in this functions dispatch, there are already tests of the fuzzy matcher that cover what caused the pain that led to this PR, and #4898 is a symptom of the much more general issue with viewing the last version of a draft before it became RFC. Lets solve the last one after the RFC-as-type-of-document major refactor. Thus, I think this simple fix should go forward so the oauth wg's issue gets resolved.

@rjsparks rjsparks marked this pull request as ready for review December 19, 2022 23:06
@rjsparks rjsparks merged commit 0f35f5d into ietf-tools:main Dec 20, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 25, 2022
@rjsparks rjsparks deleted the alternative-fix-4855 branch February 2, 2023 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAuth 2.1 links show OAuth 2.0 (Problem with drafts with version numbers in the name)

3 participants