Skip to content

fix: Don't pass an empty doc rev into ietf.doc.views_doc.document_bibtex#4880

Closed
larseggert wants to merge 1 commit into
ietf-tools:mainfrom
larseggert:fix-4878
Closed

fix: Don't pass an empty doc rev into ietf.doc.views_doc.document_bibtex#4880
larseggert wants to merge 1 commit into
ietf-tools:mainfrom
larseggert:fix-4878

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

Fixes #4878

@codecov

codecov Bot commented Dec 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4880 (9d201db) into main (a7c0cc0) will increase coverage by 0.00%.
The diff coverage is 87.23%.

@@           Coverage Diff           @@
##             main    #4880   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files         296      296           
  Lines       39755    39796   +41     
=======================================
+ Hits        35168    35205   +37     
- Misses       4587     4591    +4     
Impacted Files Coverage Δ
ietf/api/views.py 89.47% <ø> (ø)
ietf/ietfauth/urls.py 100.00% <ø> (ø)
ietf/stats/views.py 93.10% <0.00%> (ø)
ietf/submit/forms.py 82.74% <0.00%> (ø)
ietf/utils/decorators.py 87.65% <0.00%> (ø)
ietf/utils/mail.py 79.62% <0.00%> (ø)
ietf/doc/models.py 88.16% <20.00%> (-0.29%) ⬇️
ietf/nomcom/forms.py 95.39% <50.00%> (ø)
ietf/mailinglists/models.py 89.65% <66.66%> (ø)
ietf/doc/forms.py 95.50% <93.75%> (-0.50%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks

Copy link
Copy Markdown
Member

This isn't the right fix.
The bug is at the top of the function - there's no way calling this with an fyi (aka an rfc) should have landed on that line of code.
I'll propose a different fix later today.

@rjsparks

Copy link
Copy Markdown
Member

OBE by #4887

@rjsparks rjsparks closed this Dec 13, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 17, 2022
@larseggert
larseggert deleted the fix-4878 branch July 24, 2023 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

htmlized doc view failing to reverse bibtex URL for some rfcs

3 participants