Skip to content

fix: Apply various suggestions from @martinthomson #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 4 commits into from
Dec 8, 2022
Merged

fix: Apply various suggestions from @martinthomson #4849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92b1b9a
With bs 5.2.3, no need to rewrite dots in ids and hrefs.
larseggert Dec 8, 2022
262f3ba
Remove leftover console.log().
larseggert Dec 8, 2022
036ebec
Inherit color for <code>
larseggert Dec 8, 2022
8c1d203
Don't wrap boilerplate URLs; makes it look more like text version.
larseggert Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ietf/static/css/document_html.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ $tooltip-margin: inherit !default;

code {
font-size: 1em;
color: var(--bs-body-color);
color: inherit;
}

@media screen {
Expand Down
5 changes: 5 additions & 0 deletions ietf/static/css/document_html_txt.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ blockquote {
border-left: 2px solid darkgrey;
}

// Don't wrap boilerplate URLs; makes it look more like text version.
:is(#status-of-memo, #copyright) a[href] {
white-space: nowrap;
}

/* Header junk */
#external-metadata {
display: none !important; /* metadata.min.js is evil because it produces unstyleable goop */
Expand Down
15 changes: 0 additions & 15 deletions ietf/static/js/document_html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,6 @@ document.addEventListener("DOMContentLoaded", function (event) {
});
});

// Rewrite ids and hrefs to not contains dots (bug in bs5.2 scrollspy)
// See https://github.com/twbs/bootstrap/issues/34381
// TODO: check if this can be removed when bs5 is updated
const ids = document.querySelectorAll(
"#content [id^=section-], #content [id^=appendix-]");
[...ids].map(id_el => id_el.id = id_el.id.replaceAll(/\./g, "-"));
const hrefs = document.querySelectorAll(
"#content [href*='#section-'], #content [href*='#appendix-']"
);
[...hrefs].map(id_el => {
const href = new URL(id_el.href);
href.hash = href.hash.replaceAll(/\./g, "-");
id_el.href = href.href;
});

// Set up a nav pane
const toc_pane = document.getElementById("toc-nav");
populate_nav(toc_pane,
Expand Down
1 change: 0 additions & 1 deletion ietf/static/js/nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ export function populate_nav(nav, heading_selector, classes) {
document.addEventListener("scroll", debounce(function () {
const items = nav.querySelectorAll(".active");
const item = [...items].pop();
console.log(item);
if (item) {
item.scrollIntoView({
block: "center",
Expand Down