Skip to content

fix: ignore badly coded user-provided html of older documents #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 1 commit into from
Dec 7, 2022
Merged

fix: ignore badly coded user-provided html of older documents #4845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ietf/doc/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ def html_body(self, classes=""):
html = Path(
os.path.join(settings.RFC_PATH, self.canonical_name() + ".html")
).read_text()
except IOError:
except (IOError, UnicodeDecodeError):
return None
else:
try:
Expand All @@ -560,7 +560,7 @@ def html_body(self, classes=""):
self.name + "-" + self.rev + ".html",
)
).read_text()
except IOError:
except (IOError, UnicodeDecodeError):
return None

# If HTML was generated by rfc2html, do not return it. Caller
Expand Down