feat: add 'IETF Meetings' filter to upcoming meetings page#4826
Merged
rjsparks merged 4 commits intoDec 5, 2022
Conversation
Includes fixing an error in test_upcoming_view_filter_hide_type(). Due to a copy/paste error, it claimed to be testing with a type both shown and hidden but was not actually hiding a type at all.
Codecov Report
@@ Coverage Diff @@
## main #4826 +/- ##
==========================================
- Coverage 88.52% 88.46% -0.07%
==========================================
Files 296 296
Lines 39838 39752 -86
==========================================
- Hits 35266 35165 -101
- Misses 4572 4587 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rjsparks
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4807.
Changes both the
upcoming()andupcoming_ics()views to apply a keyword,ietf-meetings, to IETF meetings. This is a bit kludgy but follows the same rules as existing keywords.Note that with these changes, IETF meetings are only included in the iCalendar output when explicitly requested with that keyword. Previously, the filters affected only interim meetings and IETF meetings were always included.