fix: Allow more email addresses in notification lists#4792
Conversation
rjsparks
left a comment
There was a problem hiding this comment.
This is insufficient - a matching change to the document model is also needed, or the extra bits won't be stored in the database. See https://github.com/ietf-tools/datatracker/blob/main/ietf/doc/models.py#L111.
It's not immediately clear whether leaving this as a CharField in the model and making it significantly larger is the right thing to do. I suspect it probably needs to be converted to a TextField. Either way, the change will need to be accompanied by a migration effecting the change in the database.
(You build that with something like ietf/maange.py makemigrations doc after changing the model.)
Codecov Report
@@ Coverage Diff @@
## main #4792 +/- ##
=======================================
Coverage 88.45% 88.46%
=======================================
Files 296 296
Lines 39742 39752 +10
=======================================
+ Hits 35155 35166 +11
+ Misses 4587 4586 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jennifer-richards
left a comment
There was a problem hiding this comment.
Only comment is that I'd probably have named the migration something more descriptive (0048_lengthen_notification_lists or something), but that's a small nit. Looks good otherwise.
Fixes #4736