Skip to content

test: remove cypress + migrate existing tests to playwright#4781

Merged
rjsparks merged 6 commits into
ietf-tools:mainfrom
NGPixel:playwright-legacy
Nov 22, 2022
Merged

test: remove cypress + migrate existing tests to playwright#4781
rjsparks merged 6 commits into
ietf-tools:mainfrom
NGPixel:playwright-legacy

Conversation

@NGPixel

@NGPixel NGPixel commented Nov 22, 2022

Copy link
Copy Markdown
Member
  • Completely obliterate 💥 cypress from this project
  • Refactor existing tests to Playwright
  • Update build + PR tests workflows to run the new tests

@NGPixel
NGPixel requested a review from rjsparks November 22, 2022 08:27
@codecov

codecov Bot commented Nov 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4781 (64009fb) into main (9579f61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4781   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         296      296           
  Lines       39851    39851           
=======================================
  Hits        35273    35273           
  Misses       4578     4578           
Impacted Files Coverage Δ
ietf/utils/mail.py 79.62% <0.00%> (-0.24%) ⬇️
ietf/doc/views_search.py 89.23% <0.00%> (ø)
ietf/utils/pipe.py 86.95% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


- name: Run all tests
env:
HOME: ""

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider a comment here - the side-effect that is the point of the commit is not obvious.

@rjsparks
rjsparks merged commit deb01f2 into ietf-tools:main Nov 22, 2022
@NGPixel
NGPixel deleted the playwright-legacy branch November 22, 2022 22:55
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants