Skip to content

test: permit multiple <h1> tags in a document - #4741

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
painless-security:jennifer/multiple-h1
Nov 10, 2022
Merged

test: permit multiple <h1> tags in a document#4741
rjsparks merged 1 commit into
ietf-tools:mainfrom
painless-security:jennifer/multiple-h1

Conversation

@jennifer-richards

@jennifer-richards jennifer-richards commented Nov 9, 2022

Copy link
Copy Markdown
Member

Eliminates the failure here: https://github.com/ietf-tools/datatracker/actions/runs/3421760702/jobs/5700738094

The prohibition on multiple h1 tags is not needed - it was mostly an SEO concern and is outdated by HTML5. The code setting off the validation failure there is not new but was newly exercised by the test case added in PR #4734.

@codecov

codecov Bot commented Nov 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4741 (55e3557) into main (5b65f25) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4741      +/-   ##
==========================================
- Coverage   88.51%   88.50%   -0.01%     
==========================================
  Files         296      296              
  Lines       39840    39845       +5     
==========================================
+ Hits        35263    35266       +3     
- Misses       4577     4579       +2     
Impacted Files Coverage Δ
ietf/doc/expire.py 95.31% <100.00%> (+0.15%) ⬆️
ietf/person/views.py 77.77% <100.00%> (+0.19%) ⬆️
ietf/nomcom/utils.py 91.30% <0.00%> (-0.25%) ⬇️
ietf/utils/mail.py 79.62% <0.00%> (-0.24%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.21%) ⬇️
ietf/utils/pipe.py 86.95% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks
rjsparks merged commit eb41424 into ietf-tools:main Nov 10, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 14, 2022
@jennifer-richards
jennifer-richards deleted the jennifer/multiple-h1 branch November 15, 2022 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants