Search UI

[kivinen]

Implements #4711 i.e., allows using control-click or context menu to open items in the top right search list to open multiple documents in different tabs.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (feat/tzaware@fbd9509). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 10337a7 differs from pull request most recent head 4ec3a9b. Consider uploading reports for the commit 4ec3a9b to get more accurate results

@@               Coverage Diff               @@
##             feat/tzaware    #4716   +/-   ##
===============================================
  Coverage                ?   88.51%           
===============================================
  Files                   ?      296           
  Lines                   ?    39840           
  Branches                ?        0           
===============================================
  Hits                    ?    35263           
  Misses                  ?     4577           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[larseggert]

There are some meeting-related changes in this PR that seem unrelated?

[kivinen]

Lars Eggert writes:

There are some meeting-related changes in this PR that seem unrelated?

Most likely they are from my previous change #4701 that was already merged in. I did create new branch for these changes, but guess I should have done something else also to get rid of those changes. -- ***@***.***

[larseggert]

You need to create your new branch off tzaware, not of another branch that has changes.

[rjsparks]

At this point, it would be better to recreate this PR from current main.
I took a look at detangling this myself, and I could do so in a pinch, but I think it will be easier for Tero when he has a moment.

[kivinen]

Robert Sparks writes:

At this point, it would be better to recreate this PR from current main. I took a look at detangling this myself, and I could do so in a pinch, but I think it will be easier for Tero when he has a moment.

If you tell me how to do that I can do it, but every time I try to do something with git/github it takes about 2 hours, and couple of times, when I rm -rf everything and start over... -- ***@***.***

[rjsparks]

This is moved to #4747.

[rjsparks]

(I tried to do a soft-reset juggle, but ended up with exactly the opposite of what I wanted. I built the correct thing on a fresh checkout of main instead.)