Skip to content

fix: improve chat log rendering - #4686

Merged
rjsparks merged 2 commits into
ietf-tools:mainfrom
NGPixel:chat-log-improve
Nov 6, 2022
Merged

fix: improve chat log rendering#4686
rjsparks merged 2 commits into
ietf-tools:mainfrom
NGPixel:chat-log-improve

Conversation

@NGPixel

@NGPixel NGPixel commented Nov 1, 2022

Copy link
Copy Markdown
Member
  • Replace colon-style emojis with system emojis
  • Highlight user mentions
  • Format blockquotes
  • Hide broken inline images
  • Fix spacing of paragraphs
  • Add bs5 color reference scss variables

This PR also removes .json from the rsync assets exclude list, as its needed to fetch chat logs and is very small anyway.

@NGPixel
NGPixel requested a review from rjsparks November 1, 2022 22:26
@codecov

codecov Bot commented Nov 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4686 (0b249dd) into main (69c0f4d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4686      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.01%     
==========================================
  Files         296      296              
  Lines       39730    39730              
==========================================
- Hits        35126    35123       -3     
- Misses       4604     4607       +3     
Impacted Files Coverage Δ
ietf/nomcom/utils.py 91.26% <100.00%> (-0.25%) ⬇️
ietf/group/utils.py 93.72% <0.00%> (-0.90%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.21%) ⬇️
ietf/utils/pipe.py 86.95% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks
rjsparks merged commit 3ad1daa into ietf-tools:main Nov 6, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants