fix(nomcom-ui): Use pre instead of relying on now-missing pasted styling#4658
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4658 +/- ##
==========================================
- Coverage 88.43% 88.40% -0.03%
==========================================
Files 296 296
Lines 39716 39730 +14
==========================================
+ Hits 35122 35123 +1
- Misses 4594 4607 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 task
jennifer-richards
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the nomcom decrypt templatetag already aggressively escapes.
Somewhere along the way, the pasted class seems to have been abandoned - there is no styling for it, and nothing tries to select for it in code. Should we just remove the class at this point (this PR changes the last of the places where we were relying on its styling back to use
<pre>instead.corrects the newline part of #4634