Skip to content

fix(nomcom-ui): Use pre instead of relying on now-missing pasted styling#4658

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
rjsparks:nomcomui
Oct 28, 2022
Merged

fix(nomcom-ui): Use pre instead of relying on now-missing pasted styling#4658
rjsparks merged 1 commit into
ietf-tools:mainfrom
rjsparks:nomcomui

Conversation

@rjsparks

@rjsparks rjsparks commented Oct 26, 2022

Copy link
Copy Markdown
Member

Note that the nomcom decrypt templatetag already aggressively escapes.

Somewhere along the way, the pasted class seems to have been abandoned - there is no styling for it, and nothing tries to select for it in code. Should we just remove the class at this point (this PR changes the last of the places where we were relying on its styling back to use <pre> instead.

corrects the newline part of #4634

@codecov

codecov Bot commented Oct 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4658 (2030e27) into main (d34e88d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4658      +/-   ##
==========================================
- Coverage   88.43%   88.40%   -0.03%     
==========================================
  Files         296      296              
  Lines       39716    39730      +14     
==========================================
+ Hits        35122    35123       +1     
- Misses       4594     4607      +13     
Impacted Files Coverage Δ
ietf/utils/timezone.py 91.17% <100.00%> (+6.17%) ⬆️
ietf/doc/views_search.py 88.81% <0.00%> (-1.45%) ⬇️
ietf/utils/text.py 85.97% <0.00%> (-1.22%) ⬇️
ietf/group/utils.py 93.72% <0.00%> (-0.90%) ⬇️
ietf/utils/mail.py 79.62% <0.00%> (-0.47%) ⬇️
ietf/submit/forms.py 82.70% <0.00%> (-0.18%) ⬇️
ietf/nomcom/utils.py 91.50% <0.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit de3dbdc into ietf-tools:main Oct 28, 2022
@rjsparks rjsparks deleted the nomcomui branch October 28, 2022 15:58
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants