Skip to content

fix: Format NomCom feedback table per suggestion of @richsalz #4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 1 commit into from
Oct 21, 2022
Merged

fix: Format NomCom feedback table per suggestion of @richsalz #4625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ietf/static/js/list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,9 @@ $(document)
$(header_row)
.children("[data-sort]")
.addClass("sort");
// $(header_row)
// .children("th, td")
// .wrapInner('<span class="tablesorter-th"></span>');
// // .each((i, e) => field_magic(i, e, fields));
$(header_row)
.children("th, td")
.each((i, e) => field_magic(i, e, fields));

if ($(header_row)
.text()
Expand Down
8 changes: 3 additions & 5 deletions ietf/templates/nomcom/private_index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{% block nomcom_content %}
{% origin %}
<h2 class="mt-3">Nomination status</h2>
<table class="table table-sm table-striped table-hover tablesorter">
<table class="table table-sm table-striped-columns table-hover tablesorter">
<thead class="wrap-anywhere">
<tr>
<th scope="col" data-sort="position">Position</th>
Expand Down Expand Up @@ -156,7 +156,7 @@ <h2 class="mt-3">
<i class="bi bi-check"></i>
</th>
{% endif %}
<th scope="col" data-sort="nominee" colspan="2">
<th scope="col" data-sort="nominee">
Nominee
</th>
<th scope="col" data-sort="position">
Expand Down Expand Up @@ -194,9 +194,7 @@ <h2 class="mt-3">
<a href="{% url 'ietf.person.views.profile' email_or_name=np.nominee.name %}">
{{ np.nominee.email.name_and_email }}
</a>
</td>
<td>
<a class="btn btn-primary btn-sm"
<a class="btn btn-primary btn-sm float-end"
href="{% url 'ietf.nomcom.views.view_feedback_nominee' year=year nominee_id=np.nominee.id %}#comment">
View feedback
</a>
Expand Down