fix: stable and correct ordering of agenda items - #4621
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4621 +/- ##
=======================================
Coverage 88.39% 88.39%
=======================================
Files 296 296
Lines 39741 39709 -32
=======================================
- Hits 35130 35102 -28
+ Misses 4611 4607 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jennifer-richards
approved these changes
Oct 21, 2022
| self._all_meeting_sessions_for_group_cache = sorted(sessions, key = lambda x: x.official_timeslotassignment().timeslot.time) | ||
| sessions = [s for s in add_event_info_to_session_qs(self.meeting.session_set.filter(group=self.group)) if s.official_timeslotassignment()] | ||
| for s in sessions: | ||
| s.ota = s.official_timeslotassignment() |
Member
There was a problem hiding this comment.
After approving, noticed that this means official_timeslotassignment() is called twice for each session. Is that cheap enough (or cached effectively by the ORM) not to worry about it? There are only a couple dozen sessions filtered out in the list comprehension so it'd probably be preferable to filter the list after caching s.ota.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.