Skip to content

fix: Add value attributes back to buttons to make the logic work - #4617

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
larseggert:fix-4517
Oct 20, 2022
Merged

fix: Add value attributes back to buttons to make the logic work#4617
rjsparks merged 1 commit into
ietf-tools:mainfrom
larseggert:fix-4517

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

Fixes #4517

@codecov

codecov Bot commented Oct 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4617 (6516f87) into main (cbf3431) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4617      +/-   ##
==========================================
- Coverage   88.39%   88.38%   -0.01%     
==========================================
  Files         296      296              
  Lines       39741    39707      -34     
==========================================
- Hits        35130    35097      -33     
+ Misses       4611     4610       -1     
Impacted Files Coverage Δ
ietf/help/urls.py 100.00% <ø> (ø)
ietf/ietfauth/views.py 91.04% <ø> (+0.25%) ⬆️
ietf/doc/views_draft.py 91.94% <100.00%> (+0.04%) ⬆️
ietf/ietfauth/forms.py 95.10% <100.00%> (+0.26%) ⬆️
ietf/person/models.py 91.91% <100.00%> (+0.75%) ⬆️
ietf/person/utils.py 86.98% <100.00%> (ø)
ietf/utils/pipe.py 82.60% <0.00%> (-4.35%) ⬇️
ietf/doc/views_search.py 88.61% <0.00%> (-0.63%) ⬇️
ietf/nomcom/utils.py 90.77% <0.00%> (-0.49%) ⬇️
ietf/utils/mail.py 79.62% <0.00%> (-0.47%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks
rjsparks merged commit b1bafff into ietf-tools:main Oct 20, 2022
@larseggert
larseggert deleted the fix-4517 branch October 20, 2022 17:41
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Liaison detail form buttons do not work

2 participants