fix: Fix table sort functionality for tables with colspan attributes#4605
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4605 +/- ##
=======================================
Coverage 88.39% 88.39%
=======================================
Files 296 296
Lines 39741 39707 -34
=======================================
- Hits 35130 35100 -30
+ Misses 4611 4607 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rjsparks
reviewed
Oct 19, 2022
| @@ -62,12 +60,21 @@ $(document) | |||
| // get field classes from first thead row | |||
| var fields = $(header_row) | |||
Member
There was a problem hiding this comment.
I'm going to approve this, but this bit of new code is particularly hard to understand. I wonder if it could be written in a way that would promote better maintenance?
rjsparks
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4555