Skip to content

feat: disallow '/' from Person.name - #4594

Merged
rjsparks merged 4 commits into
ietf-tools:mainfrom
painless-security:jennifer/person-name
Oct 17, 2022
Merged

feat: disallow '/' from Person.name#4594
rjsparks merged 4 commits into
ietf-tools:mainfrom
painless-security:jennifer/person-name

Conversation

@jennifer-richards

@jennifer-richards jennifer-richards commented Oct 17, 2022

Copy link
Copy Markdown
Member

Some whitespace inadvertently got cleaned up as well, oops.

Fixes #4562

@jennifer-richards
jennifer-richards marked this pull request as draft October 17, 2022 17:14
@jennifer-richards
jennifer-richards marked this pull request as ready for review October 17, 2022 17:21
@codecov

codecov Bot commented Oct 17, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4594 (72f1c1f) into main (cbf3431) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4594      +/-   ##
==========================================
- Coverage   88.39%   88.39%   -0.01%     
==========================================
  Files         296      296              
  Lines       39741    39744       +3     
==========================================
  Hits        35130    35130              
- Misses       4611     4614       +3     
Impacted Files Coverage Δ
ietf/person/models.py 91.25% <100.00%> (+0.08%) ⬆️
ietf/utils/mail.py 79.62% <0.00%> (-0.47%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks
rjsparks merged commit fffe0c1 into ietf-tools:main Oct 17, 2022
@jennifer-richards
jennifer-richards deleted the jennifer/person-name branch October 17, 2022 20:42
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sanitize Person name when creating an account

2 participants