fix: revert photo-on-menubar enhancement#4564
Merged
rjsparks merged 2 commits intoietf-tools:mainfrom Oct 12, 2022
Merged
Conversation
jennifer-richards
approved these changes
Oct 12, 2022
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Leaves behind a now-unused .nav-link .user-photo style which should perhaps be reverted also. Up to you whether to bother.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the state of our thumbs is poor enough to make this a non-starter for now.
We need to revisit whether to clean up our image store or to shift to a third-party (gravatar, or clouflare's self-serve image manager for example).