Skip to content

feat: add slides / session materials links to session details modal#4535

Merged
rjsparks merged 9 commits intoietf-tools:mainfrom
painless-security:jennifer/propose-slides
Oct 12, 2022
Merged

feat: add slides / session materials links to session details modal#4535
rjsparks merged 9 commits intoietf-tools:mainfrom
painless-security:jennifer/propose-slides

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

Addresses some of #3725

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2022

Codecov Report

Merging #4535 (5fca3ad) into main (2981242) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

❗ Current head 5fca3ad differs from pull request most recent head 05c216d. Consider uploading reports for the commit 05c216d to get more accurate results

@@            Coverage Diff             @@
##             main    #4535      +/-   ##
==========================================
- Coverage   88.44%   88.43%   -0.01%     
==========================================
  Files         296      296              
  Lines       39701    39684      -17     
==========================================
- Hits        35112    35095      -17     
  Misses       4589     4589              
Impacted Files Coverage Δ
ietf/meeting/views.py 90.76% <80.00%> (-0.03%) ⬇️
ietf/doc/views_search.py 89.23% <0.00%> (-0.21%) ⬇️
ietf/submit/forms.py 82.70% <0.00%> (ø)
ietf/nomcom/utils.py 91.28% <0.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread playwright/tests/meeting/agenda.spec.js Outdated
Comment thread client/agenda/AgendaDetailsModal.vue Outdated
Copy link
Copy Markdown

@Ukandu147 Ukandu147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authorization code

@jennifer-richards jennifer-richards marked this pull request as ready for review October 12, 2022 16:16
@jennifer-richards
Copy link
Copy Markdown
Member Author

@rjsparks, this uses a hard-coded URL on the javascript side. @NGPixel is going to create a separate PR with improvements to the data store that will let us concentrate the URL-reversal logic in a single place as we discussed on the dev call.

@jennifer-richards
Copy link
Copy Markdown
Member Author

jennifer-richards commented Oct 12, 2022

fyi, this is the effect of this on the sessions modal. The button on the lower-right is present on all tabs of the modal and opens the materials page in a new window/tab. The 'Upload slides' button becomes 'Propose slides' if the user does not have permissions to manage the materials. It goes away entirely (except for secretariat) when the meeting is over.
Untitled

@rjsparks rjsparks merged commit 0ad293d into ietf-tools:main Oct 12, 2022
@jennifer-richards jennifer-richards deleted the jennifer/propose-slides branch October 14, 2022 20:50
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants