Skip to content

feat: stop setting MeetingRegistration.attended on MeetEcho login.#4526

Merged
rjsparks merged 3 commits into
ietf-tools:mainfrom
rjsparks:stop-setting-mr-attended
Sep 30, 2022
Merged

feat: stop setting MeetingRegistration.attended on MeetEcho login.#4526
rjsparks merged 3 commits into
ietf-tools:mainfrom
rjsparks:stop-setting-mr-attended

Conversation

@rjsparks

Copy link
Copy Markdown
Member

We capture attendence through MeetEcho using meeting.Attended now.

We capture attendence through MeetEcho using meeting.Attended now.
@rjsparks

Copy link
Copy Markdown
Member Author

cc @rpcross @alexamirante

@rjsparks
rjsparks marked this pull request as draft September 30, 2022 14:27
@rjsparks
rjsparks marked this pull request as ready for review September 30, 2022 14:38
@codecov

codecov Bot commented Sep 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4526 (ff9bde8) into main (d3f25a6) will decrease coverage by 0.00%.
The diff coverage is 85.36%.

@@            Coverage Diff             @@
##             main    #4526      +/-   ##
==========================================
- Coverage   88.43%   88.42%   -0.01%     
==========================================
  Files         296      296              
  Lines       39674    39679       +5     
==========================================
+ Hits        35086    35088       +2     
- Misses       4588     4591       +3     
Impacted Files Coverage Δ
ietf/ietfauth/utils.py 92.76% <ø> (+2.02%) ⬆️
ietf/doc/utils.py 88.12% <66.66%> (-0.46%) ⬇️
ietf/api/views.py 89.06% <100.00%> (+0.17%) ⬆️
ietf/doc/views_doc.py 90.88% <100.00%> (+0.34%) ⬆️
ietf/doc/views_search.py 89.23% <100.00%> (ø)
ietf/group/forms.py 91.41% <100.00%> (+0.16%) ⬆️
ietf/nomcom/utils.py 91.28% <100.00%> (-0.17%) ⬇️
ietf/nomcom/views.py 96.73% <100.00%> (+<0.01%) ⬆️
ietf/stats/utils.py 53.81% <100.00%> (ø)
ietf/submit/utils.py 93.60% <100.00%> (-0.02%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks
rjsparks merged commit 2058522 into ietf-tools:main Sep 30, 2022
@rjsparks
rjsparks deleted the stop-setting-mr-attended branch September 30, 2022 15:46
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants