Skip to content

feat: Add a bug report link to the menu bar - #4525

Merged
rjsparks merged 2 commits into
ietf-tools:mainfrom
larseggert:redo-menubar
Sep 30, 2022
Merged

feat: Add a bug report link to the menu bar#4525
rjsparks merged 2 commits into
ietf-tools:mainfrom
larseggert:redo-menubar

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

This required making some horizontal room for it, mostly by showing a user photo or shorter tag when they are logged in.

This required making some horizontal room for it, mostly by showing a
user photo or shorter tag when they are logged in.
@codecov

codecov Bot commented Sep 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4525 (581602e) into main (d3f25a6) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #4525      +/-   ##
==========================================
- Coverage   88.43%   88.43%   -0.01%     
==========================================
  Files         296      296              
  Lines       39674    39689      +15     
==========================================
+ Hits        35086    35098      +12     
- Misses       4588     4591       +3     
Impacted Files Coverage Δ
ietf/doc/utils.py 88.12% <66.66%> (-0.46%) ⬇️
ietf/api/views.py 89.06% <100.00%> (+0.17%) ⬆️
ietf/doc/views_doc.py 90.88% <100.00%> (+0.34%) ⬆️
ietf/doc/views_search.py 89.44% <100.00%> (+0.20%) ⬆️
ietf/group/forms.py 91.41% <100.00%> (+0.16%) ⬆️
ietf/nomcom/utils.py 91.28% <100.00%> (-0.17%) ⬇️
ietf/nomcom/views.py 96.73% <100.00%> (+<0.01%) ⬆️
ietf/stats/utils.py 53.81% <100.00%> (ø)
ietf/submit/utils.py 93.60% <100.00%> (-0.02%) ⬇️
ietf/utils/fields.py 91.57% <100.00%> (+0.04%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@larseggert

Copy link
Copy Markdown
Collaborator Author

Why does codecov still complain about 0.00% changes? I thought we had introduced some hysteresis?

@rjsparks

Copy link
Copy Markdown
Member

Why does codecov still complain about 0.00% changes? I thought we had introduced some hysteresis?

codecov and coverage are different things. We've built hysteresis into our run of coverage, but have not begun to tune codecov.

@rjsparks
rjsparks merged commit 3e2b1fc into ietf-tools:main Sep 30, 2022
@larseggert
larseggert deleted the redo-menubar branch September 30, 2022 14:22
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants