feat: include checkins at the registration desk in nomcom eligibility calculations#4519
Merged
Conversation
rjsparks
marked this pull request as draft
September 28, 2022 22:48
rjsparks
marked this pull request as ready for review
September 29, 2022 18:55
jennifer-richards
approved these changes
Sep 30, 2022
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
Looks good to me. One suggestion inline to add some comments, but not going to hold it up for that.
Codecov Report
@@ Coverage Diff @@
## main #4519 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 296 296
Lines 39674 39701 +27
=======================================
+ Hits 35086 35111 +25
- Misses 4588 4590 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
co-author: @jennifer-richards