feat: apis for attaching chatlogs and polls to session materials#4488
Merged
rjsparks merged 20 commits intoietf-tools:mainfrom Oct 13, 2022
Merged
feat: apis for attaching chatlogs and polls to session materials#4488rjsparks merged 20 commits intoietf-tools:mainfrom
rjsparks merged 20 commits intoietf-tools:mainfrom
Conversation
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Leafed through this. One detailed comment inline. API looks ok to me but it'd be nice to document the expected structure.
We're starting to see a lot of these boilerplate-ful API endpoints. Would be really nice to find a library that we could lean on instead of reinventing this each time. It'd be nice if it let us return text/plain or application/json based on the request headers, too, so that we don't hard code in that we speak JSON one way and text/plain the other.
…to provide docs for sessions that have no official timeslot assignment.
Modifications to several initial implementation decisions. Updates to the fixtures.
Refactored test to reduce duplicate code
…session materials.
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Had another look. Things look reasonable, a couple little things I noticed/wondered.
Member
Author
|
This is now only waiting for some better FE rendering of the chatlog and polls documents |
NGPixel
approved these changes
Oct 11, 2022
jennifer-richards
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very early look into where this is going, mostly so @alexamirante can comment on what the apis want to ingest.
Still much to be done - tests, initial views of the documents once we have them, etc.