Skip to content

chore: import jquery so dynamic_inlines.js source map works#4482

Merged
rjsparks merged 1 commit intoietf-tools:mainfrom
painless-security:jennifer/import-jquery
Sep 21, 2022
Merged

chore: import jquery so dynamic_inlines.js source map works#4482
rjsparks merged 1 commit intoietf-tools:mainfrom
painless-security:jennifer/import-jquery

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

Without this import, the source map Parcel generates for dynamic_inlines.js does not match up with the code.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 20, 2022

Codecov Report

Merging #4482 (bd5e7a2) into main (d3f25a6) will decrease coverage by 0.00%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##             main    #4482      +/-   ##
==========================================
- Coverage   88.43%   88.43%   -0.01%     
==========================================
  Files         296      296              
  Lines       39674    39684      +10     
==========================================
+ Hits        35086    35093       +7     
- Misses       4588     4591       +3     
Impacted Files Coverage Δ
ietf/doc/utils.py 88.12% <66.66%> (-0.46%) ⬇️
ietf/api/views.py 89.06% <100.00%> (+0.17%) ⬆️
ietf/doc/views_doc.py 90.88% <100.00%> (+0.34%) ⬆️
ietf/group/forms.py 91.41% <100.00%> (+0.16%) ⬆️
ietf/stats/utils.py 53.81% <100.00%> (ø)
ietf/submit/utils.py 93.60% <100.00%> (-0.02%) ⬇️
ietf/utils/fields.py 91.57% <100.00%> (+0.04%) ⬆️
ietf/utils/text.py 85.97% <0.00%> (-1.22%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.21%) ⬇️
ietf/submit/forms.py 82.70% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit d7bdffc into ietf-tools:main Sep 21, 2022
@jennifer-richards jennifer-richards deleted the jennifer/import-jquery branch September 22, 2022 15:25
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 26, 2022
meadmaker added a commit to meadmaker/datatracker that referenced this pull request Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants