test: Use Playwright + agenda start/end dates fix - #4471
Merged
Conversation
rjsparks
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gave up on Cypress as it would always give inconsistent results between runs and machines for no apparent reason.
Playwright is a newer alternative to Cypress, made by the VS Code team, fully open source. Instead of using the system browsers via a limited testing API, it downloads precompiled chromium, firefox and webkit binaries modified specifically for Playwright. This results in very consistent tests and bypasses many limitations present in Cypress. It's compatible with Browserstack / Percy and has great VS Code integration (code completion, validation, debugging and test panel integration).
It also has a Python version 🎉. Same exact API as the Node.js one. Could be used to replace selenium if needed, but I still think we should fully decouple the frontend / backend tests as discussed (standard unit tests for django APIs and playwright tests with mocked API responses for frontend).
Note: Cypress is still present for the 2 small nomcom tests, although it would be very quick to modify them to run in Playwright and completely get rid of Cypress.
Converted all agenda / floor plan tests to Playwright + tested them on GitHub Actions repeatedly. Multiple small tests that had to be commented out in Cypress (because of limitations or inconsistent results) are now working perfectly in Playwright.
Build workflow was modified to run Playwright tests in both chromium and firefox (in parallel).
Fixed incorrect meeting dates shown in agenda title block #4463