fix: fix failing tests and eliminate naive datetime warnings#4402
Merged
jennifer-richards merged 36 commits intoietf-tools:feat/tzawarefrom Sep 1, 2022
Merged
Conversation
Replaces the PRODUCTION_TIMEZONE setting with a constant, DEADLINE_TZINFO, in ietf.utils.timezone.
Manual cherry-pick of 248d647
rjsparks
approved these changes
Sep 1, 2022
Member
|
One thought: The DEADLINE_TZINFO idea is invoked when we have endpoint times, but may need to apply for start times as well. |
Member
Author
|
Good point. I meant to use it for any timestamp that represents either end of an interval, including where comparing "today" to endpoints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests now pass and no datetime warnings are emitted during the tests.
I've replaced the formerly unused
PRODUCTION_TIMEZONEsetting with the constantDEADLINE_TZINFOinietf/utils/timezone.py. The constant is atzinforather than a string. My intention was to use this when silently convertingdateinstances todatetimeinstances where the current behavior assumes pacific time. In other cases, I've generally let things default to UTC.That's the intention, but obviously, trust no one when time zones are involved.