Skip to content

fix: move check and migrate into prepare.sh for dev/diff. #4397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 1 commit into from
Aug 31, 2022
Merged

fix: move check and migrate into prepare.sh for dev/diff. #4397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions dev/diff/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,10 +700,6 @@ async function main () {
task: async (subctx, subtask) => {
await executeCommand(subtask, containers.appSource, ['bash', '-c', 'chmod +x ./dev/diff/prepare.sh'])
await executeCommand(subtask, containers.appSource, ['bash', './dev/diff/prepare.sh'])
subtask.title = `Preparing source Datatracker instance - Running checks...`
await executeCommand(subtask, containers.appSource, ['bash', '-c', './ietf/manage.py check'])
subtask.title = `Preparing source Datatracker instance - Applying migrations...`
await executeCommand(subtask, containers.appSource, ['bash', '-c', './ietf/manage.py migrate'])
subtask.title = `Source Datatracker instance is now ready.`
}
},
Expand All @@ -712,10 +708,6 @@ async function main () {
task: async (subctx, subtask) => {
await executeCommand(subtask, containers.appTarget, ['bash', '-c', 'chmod +x ./dev/diff/prepare.sh'])
await executeCommand(subtask, containers.appTarget, ['bash', './dev/diff/prepare.sh'])
subtask.title = `Run target Datatracker instance - Running checks...`
await executeCommand(subtask, containers.appTarget, ['bash', '-c', './ietf/manage.py check'])
subtask.title = `Run target Datatracker instance - Applying migrations...`
await executeCommand(subtask, containers.appTarget, ['bash', '-c', './ietf/manage.py migrate'])
subtask.title = `Run target Datatracker instance - Starting server...`
executeCommand(subtask, containers.appTarget, ['bash', '-c', './ietf/manage.py runserver 0.0.0.0:8000 --settings=settings_local'])
subtask.title = `Run target Datatracker instance - Waiting for server to accept connections...`
Expand Down
2 changes: 2 additions & 0 deletions dev/diff/prepare.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ yarn legacy:build
echo "Creating data directories..."
chmod +x ./docker/scripts/app-create-dirs.sh
./docker/scripts/app-create-dirs.sh
./ietf/manage.py check
./ietf/manage.py migrate